<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100039/">http://git.reviewboard.kde.org/r/100039/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 21st, 2010, 5:21 p.m., <b>Mark Kretschmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Has this already been pushed to mainline? It says "Patch Reversed" here, but I can't find it in the git log. *confused*
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It's pushed.
19ddc6090404a4fb41b0d1e8a10cfa5a9f475b45</pre>
<br />
<p>- Ralf</p>
<br />
<p>On October 20th, 2010, 3:38 p.m., Ralf Engels wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Ralf Engels.</div>
<p style="color: grey;"><i>Updated 2010-10-20 15:38:41</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixes three problems:
1. Alignment was not considered with rating widget when editing
2. Calculation of item height was incorrect leading to the problem that three line items would not show the third line when editing
3. QStyle pixel metrics were disregarded
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Editing with one, two and three line layouts.
Using Oxygen and normal styles.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/playlist/view/listview/InlineEditorWidget.h <span style="color: grey">(f14d6df)</span></li>
<li>src/playlist/view/listview/InlineEditorWidget.cpp <span style="color: grey">(a7e981b)</span></li>
<li>src/playlist/view/listview/PrettyItemDelegate.h <span style="color: grey">(a929ecb)</span></li>
<li>src/playlist/view/listview/PrettyItemDelegate.cpp <span style="color: grey">(183f9cd)</span></li>
<li>src/playlist/view/listview/PrettyListView.cpp <span style="color: grey">(538cbaa)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100039/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100039/s/6/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2010/10/19/inline-editing-before_400x100.png" style="border: 1px black solid;" alt="Before" /></a>
<a href="http://git.reviewboard.kde.org/r/100039/s/7/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2010/10/19/inline-editing-after_400x100.png" style="border: 1px black solid;" alt="After (stars too small, text clipping)" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>