<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100030/">http://git.reviewboard.kde.org/r/100030/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 9th, 2010, 4:56 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes it does ;-)
(be aware that i wrote that "just down" - the vars/classnames might slightly differ and there're likely typos =)
MainWindow::setDockAsCurrentTabWidget( char docktype )
{
QDockWidget *dock(0);
switch (docktype)
{
case 'p': dock = playlistDock; break;
case 'c': dock = contextDock; break;
case 'm': dock = mediaSourcesDock; break;
default: return; // invalid request
}
if ( !tabifiedDockWidgets(dock).isEmpty() ) // is actually tabbed
tabifyDockWidget( docks.at(docks.count()-1), dock ); // tabify moves second on top of first, either 0 or c-1 should do...
} </pre>
</blockquote>
<p>On October 9th, 2010, 5:01 p.m., <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">d'oooh - oc. it must be sth. like
QList<QDockWidget*> docks = tabifiedDockWidgets(dock);
if (!docks.isEmpty())
...
(ie. forgot to define docks ;-)</pre>
</blockquote>
<p>On October 9th, 2010, 10:30 p.m., <b>Daniel Faust</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, now I got it.
But it still doesn't solve the problem properly. The second dock is not only moved above the fist one but also to the right of it.
So if I try to give the most left dock the focus it gets moved to the right of the reference dock. (very irritating)</pre>
</blockquote>
<p>On October 16th, 2010, 10:11 a.m., <b>Mark Kretschmann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Any progress with this one?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I should rather not group mails by week ;-)
Daniel is right and unfortunately there's no clean way to prevent this (you'd have to store and restore the tab order, but therefore you'd need to identify the tabbar as well as the position of the demanded dock)
Since the QDockAreaLayout is (unfortunately.) private there's really no clean solution for this :-(</pre>
<br />
<p>- Thomas</p>
<br />
<p>On October 8th, 2010, 12:51 p.m., Daniel Faust wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Daniel Faust.</div>
<p style="color: grey;"><i>Updated 2010-10-08 12:51:02</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since I have tabbed my Navigation and Context views I have to manually select the tabs every time I open a bookmark.
In my opinion this should be done automatically.
Unfortunately I couldn't come up with a very clean solution. But please have a look at the code yourself and share your opinion.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm running amarok with this patch for many weeks now without any problems.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/MainWindow.h <span style="color: grey">(b86470e)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(54c6751)</span></li>
<li>src/amarokurls/ContextUrlRunner.cpp <span style="color: grey">(7416fbc)</span></li>
<li>src/amarokurls/NavigationUrlRunner.cpp <span style="color: grey">(6bb6c0b)</span></li>
<li>src/playlist/PlaylistViewUrlRunner.cpp <span style="color: grey">(749233e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100030/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>