<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100053/">http://git.reviewboard.kde.org/r/100053/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks great, and works the same. Thank you.</pre>
<br />
<p>- Sergey</p>
<br />
<p>On October 10th, 2010, 5:54 a.m., Alexander Potashev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Alexander Potashev.</div>
<p style="color: grey;"><i>Updated 2010-10-10 05:54:28</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The translated column names (columnNames) cannot be stored in PlaylistDefines.h, because they can only be obtained in run-time. In this patch I use a singleton class which generates a list of translated columns at the first time when it is required.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=189750">189750</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(f135a86)</span></li>
<li>src/playlist/PlaylistBreadcrumbItem.cpp <span style="color: grey">(7e0a9cd)</span></li>
<li>src/playlist/PlaylistBreadcrumbLevel.cpp <span style="color: grey">(e86d455)</span></li>
<li>src/playlist/PlaylistColumnNames.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/playlist/PlaylistColumnNames.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/playlist/PlaylistDefines.h <span style="color: grey">(8a0713e)</span></li>
<li>src/playlist/PlaylistModel.cpp <span style="color: grey">(f462dbf)</span></li>
<li>src/playlist/layouts/LayoutEditWidget.cpp <span style="color: grey">(1d87ec8)</span></li>
<li>src/playlist/layouts/PlaylistLayoutEditDialog.cpp <span style="color: grey">(686ea6b)</span></li>
<li>src/playlist/proxymodels/SortScheme.cpp <span style="color: grey">(0746559)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100053/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>