On Tue, Oct 12, 2010 at 10:12 AM, Andy Coder <span dir="ltr"><<a href="mailto:andrew.coder@gmail.com">andrew.coder@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div>(Just an aside in response to the issues Max raised)</div><div><br></div>As far as getting this up soon, it seems I was being way too optimistic. I've got papers/exams right now, and I'll be on the road Wednesday-Saturday. Even if I did the code now, I'm even having read access denied by git, and definitely don't have time to deal with that and make changes, (and everything external).</blockquote>
<div><br></div><div>You likely need to update your Git remote path.</div><div><br></div><div>Edit .git/config in your Amarok Git clone, and ensure the url is git@git.kde.org:amarok.git</div><div><br></div><div>Regards,</div>
<div>Ben</div><div><br></div><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div>If anyone feels like doing it themselves, go for it, but this will all otherwise have to wait until next week.</div>
<div><br></div><div><font color="#888888"> - Andy Coder</font><div><div class="h5"><br><br><div class="gmail_quote">On Sat, Oct 9, 2010 at 1:26 PM, Andy Coder <span dir="ltr"><<a href="mailto:andrew.coder@gmail.com" target="_blank">andrew.coder@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana, Arial, Helvetica, Sans-Serif"><div>
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 solid">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100001/" target="_blank">http://git.reviewboard.kde.org/r/100001/</a>
</td>
</tr>
</tbody></table>
<br>
</div><div><blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<p style="margin-top:0">On October 9th, 2010, 10:52 a.m., <b>Maximilian Kossick</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<table width="100%" border="0" bgcolor="white" style="border:1px solid #C0C0C0;border-collapse:collapse">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom:1px solid #C0C0C0;font-size:9pt;padding:4px 8px;text-align:left">
<a href="http://git.reviewboard.kde.org/r/100001/diff/1/?file=154#file154line104" style="color:black;font-weight:bold;text-decoration:underline" target="_blank">src/core-impl/collections/playdarcollection/PlaydarCollection.h</a>
<span style="font-weight:normal">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color:#e4d9cb;padding:4px 8px;text-align:center">
<tr>
<td colspan="2"></td>
<td colspan="2"><pre style="font-size:8pt;line-height:140%;margin:0">namespace Collections</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right:1px solid #C0C0C0" align="right"></th>
<td bgcolor="#c5ffc4" width="50%"></td>
<th bgcolor="#b1ebb0" style="border-left:1px solid #C0C0C0;border-right:1px solid #C0C0C0" align="right"><font size="2">104</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"> <span>QList</span><span><</span> <span>QPointer</span><span><</span> <span>Playdar</span><span>::</span><span>ProxyResolver</span> <span>></span> <span>></span> <span>m_proxyResolverList</span><span>;</span></pre>
</td>
</tr>
</tbody>
</table>
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">This should be switched to using QWeakPointer now that we use Qt 4.6. Additionally, you might want to use QWeakPointer::toStrongRef whenever you actually need to work with a Resolver.</pre>
</blockquote>
</blockquote>
</div><pre style="margin-left:1em;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Yeah, I noticed the QWeakPointer review, and I'm happy to take care of it in my code, (tomorrow, probably).</pre>
<div>
<br>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<p style="margin-top:0">On October 9th, 2010, 10:52 a.m., <b>Maximilian Kossick</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<table width="100%" border="0" bgcolor="white" style="border:1px solid #C0C0C0;border-collapse:collapse">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom:1px solid #C0C0C0;font-size:9pt;padding:4px 8px;text-align:left">
<a href="http://git.reviewboard.kde.org/r/100001/diff/2/?file=286#file286line183" style="color:black;font-weight:bold;text-decoration:underline" target="_blank">src/core-impl/collections/playdarcollection/PlaydarCollection.cpp</a>
<span style="font-weight:normal">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color:#e4d9cb;padding:4px 8px;text-align:center">
<tr>
<td colspan="2"></td>
<td colspan="2"><pre style="font-size:8pt;line-height:140%;margin:0">namespace Collections</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right:1px solid #C0C0C0" align="right"></th>
<td bgcolor="#c5ffc4" width="50%"></td>
<th bgcolor="#b1ebb0" style="border-left:1px solid #C0C0C0;border-right:1px solid #C0C0C0" align="right"><font size="2">183</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"> <span>DEBUG_BLOCK</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Is this really necessary?</pre> </blockquote>
</blockquote>
</div><pre style="margin-left:1em;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">It was when I just wanted to know what was getting called by user code, but there's probably a good number of these that aren't really helpful when debugging anymore.</pre>
<div>
<br>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<p style="margin-top:0">On October 9th, 2010, 10:52 a.m., <b>Maximilian Kossick</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<table width="100%" border="0" bgcolor="white" style="border:1px solid #C0C0C0;border-collapse:collapse">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom:1px solid #C0C0C0;font-size:9pt;padding:4px 8px;text-align:left">
<a href="http://git.reviewboard.kde.org/r/100001/diff/2/?file=286#file286line263" style="color:black;font-weight:bold;text-decoration:underline" target="_blank">src/core-impl/collections/playdarcollection/PlaydarCollection.cpp</a>
<span style="font-weight:normal">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color:#e4d9cb;padding:4px 8px;text-align:center">
<tr>
<td colspan="2"></td>
<td colspan="2"><pre style="font-size:8pt;line-height:140%;margin:0">namespace Collections</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right:1px solid #C0C0C0" align="right"></th>
<td bgcolor="#c5ffc4" width="50%"></td>
<th bgcolor="#b1ebb0" style="border-left:1px solid #C0C0C0;border-right:1px solid #C0C0C0" align="right"><font size="2">263</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"> <span>if</span><span>(</span> <span>!</span><span>m_memoryCollection</span><span>-></span><span>trackMap</span><span>().</span><span>contains</span><span>(</span> <span>track</span><span>-></span><span>uidUrl</span><span>()</span> <span>)</span> <span>)</span></pre>
</td>
</tr>
</tbody>
</table>
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">I'd recommend inverting this check. That way it becomes a lot clearer which lock you are releasing in the (current) else block.</pre>
</blockquote>
</blockquote>
</div><pre style="margin-left:1em;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Seems reasonable, it is an unfortunately long block of code between acquiring and releasing the lock, (even though it happens right away).</pre>
<div>
<br>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<p style="margin-top:0">On October 9th, 2010, 10:52 a.m., <b>Maximilian Kossick</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<table width="100%" border="0" bgcolor="white" style="border:1px solid #C0C0C0;border-collapse:collapse">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom:1px solid #C0C0C0;font-size:9pt;padding:4px 8px;text-align:left">
<a href="http://git.reviewboard.kde.org/r/100001/diff/2/?file=288#file288line252" style="color:black;font-weight:bold;text-decoration:underline" target="_blank">src/core-impl/collections/playdarcollection/PlaydarMeta.cpp</a>
<span style="font-weight:normal">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color:#e4d9cb;padding:4px 8px;text-align:center">
<tr>
<td colspan="2"></td>
<td colspan="2"><pre style="font-size:8pt;line-height:140%;margin:0">uint</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right:1px solid #C0C0C0" align="right"></th>
<td bgcolor="#c5ffc4" width="50%"></td>
<th bgcolor="#b1ebb0" style="border-left:1px solid #C0C0C0;border-right:1px solid #C0C0C0" align="right"><font size="2">252</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"><span>Meta</span><span>::</span><span>PlaydarTrack</span><span>::</span><span>lastPlayed</span><span>()</span> <span>const</span></pre>
</td>
</tr>
</tbody>
</table>
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Please look at using the already existing statistics provider to provide the statistics related values (e.g. playcount, lastplayed, rating). They will persist the data.</pre>
</blockquote>
</blockquote>
</div><pre style="margin-left:1em;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Will do.</pre><div>
<br>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<p style="margin-top:0">On October 9th, 2010, 10:52 a.m., <b>Maximilian Kossick</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<table width="100%" border="0" bgcolor="white" style="border:1px solid #C0C0C0;border-collapse:collapse">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom:1px solid #C0C0C0;font-size:9pt;padding:4px 8px;text-align:left">
<a href="http://git.reviewboard.kde.org/r/100001/diff/2/?file=290#file290line39" style="color:black;font-weight:bold;text-decoration:underline" target="_blank">src/core-impl/collections/playdarcollection/PlaydarQueryMaker.cpp</a>
<span style="font-weight:normal">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color:#e4d9cb;padding:4px 8px;text-align:center">
<tr>
<td colspan="2"></td>
<td colspan="2"><pre style="font-size:8pt;line-height:140%;margin:0">namespace Collections</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right:1px solid #C0C0C0" align="right"></th>
<td bgcolor="#c5ffc4" width="50%"></td>
<th bgcolor="#b1ebb0" style="border-left:1px solid #C0C0C0;border-right:1px solid #C0C0C0" align="right"><font size="2">39</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"> <span>,</span> <span>m_autoDelete</span><span>(</span> <span>false</span> <span>)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Why are you reimplementing the autoDelete functionality? QueryMaker already uses provides the autoDeletion upon emitting queryDone(). I cannot find any reason to override that behaviour in this code</pre>
</blockquote>
</blockquote>
</div><pre style="margin-left:1em;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">I must have missed that one. There might still be something needed since PlaydarQueryMaker manages a MemoryQueryMaker, but I'll have a look at it.</pre>
<div>
<br>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<p style="margin-top:0">On October 9th, 2010, 10:52 a.m., <b>Maximilian Kossick</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<table width="100%" border="0" bgcolor="white" style="border:1px solid #C0C0C0;border-collapse:collapse">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom:1px solid #C0C0C0;font-size:9pt;padding:4px 8px;text-align:left">
<a href="http://git.reviewboard.kde.org/r/100001/diff/2/?file=290#file290line377" style="color:black;font-weight:bold;text-decoration:underline" target="_blank">src/core-impl/collections/playdarcollection/PlaydarQueryMaker.cpp</a>
<span style="font-weight:normal">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color:#e4d9cb;padding:4px 8px;text-align:center">
<tr>
<td colspan="2"></td>
<td colspan="2"><pre style="font-size:8pt;line-height:140%;margin:0">namespace Collections</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right:1px solid #C0C0C0" align="right"></th>
<td bgcolor="#c5ffc4" width="50%"></td>
<th bgcolor="#b1ebb0" style="border-left:1px solid #C0C0C0;border-right:1px solid #C0C0C0" align="right"><font size="2">377</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"> <span>PlaydarQueryMaker</span><span>::</span><span>addMatch</span><span>(</span> <span>const</span> <span>Meta</span><span>::</span><span>DataPtr</span> <span>&</span><span>data</span> <span>)</span></pre>
</td>
</tr>
</tbody>
</table>
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">I'm pretty sure that this is identical to the implementation in QueryMaker itself. If so, please remove it here.</pre>
</blockquote>
</blockquote>
</div><pre style="margin-left:1em;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">QueryMaker.h:
160 virtual QueryMaker* addMatch( const Meta::DataPtr &data ) = 0;
Admittedly, I think this is how every other QueryMaker implements it, so it probably should be in QueryMaker itself, but it definitely isn't.</pre><div>
<br>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<p style="margin-top:0">On October 9th, 2010, 10:52 a.m., <b>Maximilian Kossick</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<table width="100%" border="0" bgcolor="white" style="border:1px solid #C0C0C0;border-collapse:collapse">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom:1px solid #C0C0C0;font-size:9pt;padding:4px 8px;text-align:left">
<a href="http://git.reviewboard.kde.org/r/100001/diff/2/?file=292#file292line52" style="color:black;font-weight:bold;text-decoration:underline" target="_blank">src/core-impl/collections/playdarcollection/support/Controller.h</a>
<span style="font-weight:normal">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color:#e4d9cb;padding:4px 8px;text-align:center">
<tr>
<td colspan="2"></td>
<td colspan="2"><pre style="font-size:8pt;line-height:140%;margin:0">namespace Playdar</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right:1px solid #C0C0C0" align="right"></th>
<td bgcolor="#c5ffc4" width="50%"></td>
<th bgcolor="#b1ebb0" style="border-left:1px solid #C0C0C0;border-right:1px solid #C0C0C0" align="right"><font size="2">52</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"><span> * We invoke the private function status() here, return immediately,</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Internal behaviour should generally not be put into the API documentaton. In my opinion it is sufficient for users to understand that they have to wait for the playdarReady or playdarError signal before they can use the controller.</pre>
</blockquote>
</blockquote>
</div><pre style="margin-left:1em;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Yeah... The docs here aren't correct, but I'll keep the note about internal behaviour in mind. This should get updated today/tomorrow.</pre>
<div>
<br>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<p style="margin-top:0">On October 9th, 2010, 10:52 a.m., <b>Maximilian Kossick</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px">
<table width="100%" border="0" bgcolor="white" style="border:1px solid #C0C0C0;border-collapse:collapse">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom:1px solid #C0C0C0;font-size:9pt;padding:4px 8px;text-align:left">
<a href="http://git.reviewboard.kde.org/r/100001/diff/2/?file=293#file293line55" style="color:black;font-weight:bold;text-decoration:underline" target="_blank">src/core-impl/collections/playdarcollection/support/Controller.cpp</a>
<span style="font-weight:normal">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color:#e4d9cb;padding:4px 8px;text-align:center">
<tr>
<td colspan="2"></td>
<td colspan="2"><pre style="font-size:8pt;line-height:140%;margin:0">namespace Playdar {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right:1px solid #C0C0C0" align="right"></th>
<td bgcolor="#c5ffc4" width="50%"></td>
<th bgcolor="#b1ebb0" style="border-left:1px solid #C0C0C0;border-right:1px solid #C0C0C0" align="right"><font size="2">55</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size:8pt;line-height:140%;margin:0"> <span>const</span> <span>QString</span> <span>baseUrl</span><span>(</span> <span>"<a href="http://localhost:60210/api/?method=resolve" target="_blank">http://localhost:60210/api/?method=resolve</a>"</span> <span>);</span></pre>
</td>
</tr>
</tbody>
</table>
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">It might make sense to create an internal method, e.g. "serverUrl", which returns a KUrl containing everything but the request parameters. That way you write the url only once now and can make ther server configurable in the future.</pre>
</blockquote>
</blockquote>
</div><pre style="margin-left:1em;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Yep.</pre><br><font color="#888888">
<p>- Andy</p></font><div>
<br>
<p>On September 25th, 2010, 6:21 p.m., Andy Coder wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-repeat:repeat-x;border:1px black solid">
<tbody><tr>
<td>
<div>Review request for Amarok and Leo Franchi.</div>
<div>By Andy Coder.</div>
<p style="color:grey"><i>Updated 2010-09-25 18:21:06</i></p>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">This is what it does, (basically):
1) Adds the PlaydarCollection/QueryMaker/Meta/etc. code in src/core-impl/collections/playdar-collection/
2) Adds the top-level external/ directory and moves JsonQt into it
3) Changes the formerly unused side of the behavior of MetaProxy::Track,
(when AwaitLookupNotification == false), so that PlaydarTracks can sit
around and eventually get updated without slowing things to a crawl
4) Changes CurrentEngine and the SimilarArtists applet' use of
CollectionManager::instance()->primaryCollection() to ->queryMaker()
5) Adds the 'Add top track to playlist' button to SimilarArtists
6) Prevents XSPFPlaylist from killing of MetaProxy::Tracks just
because they're not playable yet</pre> </td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>src/core-impl/collections/playdarcollection/PlaydarCollection.cpp <span style="color:grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/playdarcollection/support/ProxyResolver.cpp <span style="color:grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100001/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100001/s/2/" target="_blank"><img style="border:1px black solid" alt="It works! (for me)"></a>
</div>
</td>
</tr>
</tbody></table>
</div></div>
</div>
</blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
Amarok-devel mailing list<br>
<a href="mailto:Amarok-devel@kde.org">Amarok-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/amarok-devel" target="_blank">https://mail.kde.org/mailman/listinfo/amarok-devel</a><br>
<br></blockquote><br>