<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100011/">http://git.reviewboard.kde.org/r/100011/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Mark Kretschmann.</div>
<p style="color: grey;"><i>Updated 2010-10-08 08:00:54.657094</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Made more progress with the conversion. Still lots to do (well, it's hard to estimate how much remains, maybe it's almost done).
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Convert all uses of QPointer to QWeakPointer, for better performance.
See http://doc.trolltech.com/4.6/qweakpointer.html
Unfortunately this is pretty monotonous work, as QWeakPointer doesn't
support all normal pointer semantics, e.g. no foo->blah(). I got pretty far,
but then had to give up at a strange compiler error.
Anyone want to help finishing it?
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixed error after error (lots of pointer dereferences needed changing), but got stuck at one particular compile error. Help appreciated.
foo->blah() must be changed to foo.data()->blah() to work with QWeakPointer.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ActionClasses.h <span style="color: grey">(bf0149d)</span></li>
<li>src/App.h <span style="color: grey">(5866aa2)</span></li>
<li>src/EngineController.h <span style="color: grey">(ecd81e9)</span></li>
<li>src/MainWindow.h <span style="color: grey">(b86470e)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(54c6751)</span></li>
<li>src/TrayIcon.h <span style="color: grey">(2cb3eca)</span></li>
<li>src/browsers/BrowserDock.h <span style="color: grey">(cf99dad)</span></li>
<li>src/browsers/BrowserDock.cpp <span style="color: grey">(06d6320)</span></li>
<li>src/context/ContextDock.h <span style="color: grey">(06fe848)</span></li>
<li>src/context/ContextDock.cpp <span style="color: grey">(fd8d1a1)</span></li>
<li>src/context/ContextView.h <span style="color: grey">(2a6ff7d)</span></li>
<li>src/context/ToolbarView.h <span style="color: grey">(95ea6af)</span></li>
<li>src/context/ToolbarView.cpp <span style="color: grey">(bb0f065)</span></li>
<li>src/context/applets/labels/LabelsApplet.h <span style="color: grey">(fdef463)</span></li>
<li>src/context/applets/videoclip/VideoclipApplet.h <span style="color: grey">(38edb46)</span></li>
<li>src/context/engines/labels/LabelsEngine.h <span style="color: grey">(497d7fe)</span></li>
<li>src/core-impl/collections/daap/DaapCollection.h <span style="color: grey">(fdba0af)</span></li>
<li>src/core-impl/collections/daap/DaapCollection.cpp <span style="color: grey">(253fe12)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h <span style="color: grey">(56dd268)</span></li>
<li>src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp <span style="color: grey">(4b39d7c)</span></li>
<li>src/core-impl/collections/mtpcollection/handler/capabilities/MtpReadCapability.h <span style="color: grey">(464db43)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlCollection.h <span style="color: grey">(89fcdc0)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlMeta.cpp <span style="color: grey">(5000ec1)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlQueryMaker.cpp <span style="color: grey">(714fac7)</span></li>
<li>src/core-impl/collections/sqlcollection/SqlQueryMakerInternal.h <span style="color: grey">(98e6976)</span></li>
<li>src/core-impl/collections/support/MemoryQueryMakerInternal.h <span style="color: grey">(fa2a7f5)</span></li>
<li>src/core-impl/logger/ProxyLogger.h <span style="color: grey">(f321ca0)</span></li>
<li>src/core-impl/meta/file/File.cpp <span style="color: grey">(0b86acb)</span></li>
<li>src/core-impl/meta/proxy/MetaProxy.cpp <span style="color: grey">(316baaa)</span></li>
<li>src/core-impl/meta/stream/Stream.cpp <span style="color: grey">(c86d495)</span></li>
<li>src/core/engine/EngineObserver.h <span style="color: grey">(449677b)</span></li>
<li>src/core/support/Amarok.h <span style="color: grey">(a4fb497)</span></li>
<li>src/core/support/Amarok.cpp <span style="color: grey">(33d9d0b)</span></li>
<li>src/covermanager/CoverFetcher.h <span style="color: grey">(335e0ce)</span></li>
<li>src/covermanager/CoverFoundDialog.h <span style="color: grey">(ca83535)</span></li>
<li>src/covermanager/CoverFoundDialog.cpp <span style="color: grey">(5f5406a)</span></li>
<li>src/dynamic/Bias.h <span style="color: grey">(6ec60b6)</span></li>
<li>src/dynamic/Bias.cpp <span style="color: grey">(1708718)</span></li>
<li>src/dynamic/BiasedPlaylist.h <span style="color: grey">(a178e93)</span></li>
<li>src/dynamic/BiasedPlaylist.cpp <span style="color: grey">(35946af)</span></li>
<li>src/network/NetworkAccessManagerProxy.cpp <span style="color: grey">(d60eb4e)</span></li>
<li>src/playlist/PlaylistDock.h <span style="color: grey">(ea13089)</span></li>
<li>src/playlist/PlaylistDock.cpp <span style="color: grey">(1f09769)</span></li>
<li>src/playlist/layouts/LayoutEditDialog.h <span style="color: grey">(ef602f9)</span></li>
<li>src/playlist/layouts/LayoutEditDialog.cpp <span style="color: grey">(528bcc3)</span></li>
<li>src/services/lastfm/LastFmTreeView.h <span style="color: grey">(6e16000)</span></li>
<li>src/services/lastfm/meta/LastFmMeta.cpp <span style="color: grey">(3183521)</span></li>
<li>src/widgets/MetaQueryWidget.h <span style="color: grey">(4d544c7)</span></li>
<li>src/widgets/MetaQueryWidget.cpp <span style="color: grey">(5f9171a)</span></li>
<li>src/widgets/TokenWithLayout.h <span style="color: grey">(bb71ac8)</span></li>
<li>src/widgets/TokenWithLayout.cpp <span style="color: grey">(c5451d0)</span></li>
<li>src/widgets/VolumeWidget.h <span style="color: grey">(097cf6a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100011/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>