<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100026/">http://git.reviewboard.kde.org/r/100026/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for amarok and Bart Cerneels.</div>
<div>By Nikhil Shantanu Marathe.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Slave Git repository URL: http://gitorious.org/kio-upnp-ms/mainline/commits/master
Review request for the UPnP Kioslave created as part of Google Summer of Code 2010. Bart Cerneels requested I create a request here so the Amarok team could have a look. I know the lack of a diff is pretty inconvenient though. If it is possible to create it as a repo on git.kde.org I could do that.
This slave reserves the 'upnp-ms' URL scheme and requires the HUpnp library (http://www.herqq.org).
As part of integration of UPnP collection support in Amarok, and pervasive UPnP support in Solid, Herqq will be a dependency, though it could eventually be a kdelibs dependency too.
The slave is fully functional for browsing and searching and is stable as far as I've tested it. The README file has more details and HACKING has some idea of code organization.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It works with most open source UPnP servers and some real hardware too.
It seems to have problems with Windows Media Player shares sometimes, but I suspect it is an upstream (HUpnp) bug.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100026/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>