<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100001/">http://git.reviewboard.kde.org/r/100001/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for amarok and Leo Franchi.</div>
<div>By Andy Coder.</div>
<p style="color: grey;"><i>Updated 2010-09-25 18:02:52.397941</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Addressed Leo's notes and added a blurb to the ChangeLog</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is what it does, (basically):
1) Adds the PlaydarCollection/QueryMaker/Meta/etc. code in src/core-impl/collections/playdar-collection/
2) Adds the top-level external/ directory and moves JsonQt into it
3) Changes the formerly unused side of the behavior of MetaProxy::Track,
(when AwaitLookupNotification == false), so that PlaydarTracks can sit
around and eventually get updated without slowing things to a crawl
4) Changes CurrentEngine and the SimilarArtists applet' use of
CollectionManager::instance()->primaryCollection() to ->queryMaker()
5) Adds the 'Add top track to playlist' button to SimilarArtists
6) Prevents XSPFPlaylist from killing of MetaProxy::Tracks just
because they're not playable yet</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(191b02e)</span></li>
<li>ChangeLog <span style="color: grey">(a7f2460)</span></li>
<li>external/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/COMPATIBILITY <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/COPYING.HEADER <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/Doxyfile.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/README.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/add-copyright-header.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/lib/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/lib/JsonQtExport.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/lib/JsonRpc.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/lib/JsonRpc.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/lib/JsonRpcAdaptor.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/lib/JsonRpcAdaptor.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/lib/JsonRpcAdaptorPrivate.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/lib/JsonRpcAdaptorPrivate.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/lib/JsonToProperties.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/lib/JsonToProperties.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/lib/JsonToVariant.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/lib/JsonToVariant.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/lib/ParseException.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/lib/ParseException.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/lib/VariantToJson.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/lib/VariantToJson.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/tests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/tests/JsonRpc.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/tests/JsonRpcAdaptor.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/tests/JsonToProperties.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/tests/JsonToVariant.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/JsonQt/tests/VariantToJson.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>external/README.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/context/applets/similarartists/ArtistWidget.h <span style="color: grey">(a9331f6)</span></li>
<li>src/context/applets/similarartists/ArtistWidget.cpp <span style="color: grey">(702248e)</span></li>
<li>src/context/engines/current/CurrentEngine.cpp <span style="color: grey">(bb8e869)</span></li>
<li>src/context/engines/songkick/CMakeLists.txt <span style="color: grey">(fab9a28)</span></li>
<li>src/context/engines/songkick/JsonQt/CMakeLists.txt <span style="color: grey">(9978895)</span></li>
<li>src/context/engines/songkick/JsonQt/COMPATIBILITY <span style="color: grey">(1a5b619)</span></li>
<li>src/context/engines/songkick/JsonQt/COPYING.HEADER <span style="color: grey">(bf9c30e)</span></li>
<li>src/context/engines/songkick/JsonQt/Doxyfile.cmake <span style="color: grey">(4d2a4bf)</span></li>
<li>src/context/engines/songkick/JsonQt/README.txt <span style="color: grey">(4ebcf73)</span></li>
<li>src/context/engines/songkick/JsonQt/add-copyright-header.sh <span style="color: grey">(8d21c92)</span></li>
<li>src/context/engines/songkick/JsonQt/lib/CMakeLists.txt <span style="color: grey">(3d39457)</span></li>
<li>src/context/engines/songkick/JsonQt/lib/JsonQtExport.h <span style="color: grey">(d7024e5)</span></li>
<li>src/context/engines/songkick/JsonQt/lib/JsonRpc.h <span style="color: grey">(8f0024c)</span></li>
<li>src/context/engines/songkick/JsonQt/lib/JsonRpc.cpp <span style="color: grey">(cbcd161)</span></li>
<li>src/context/engines/songkick/JsonQt/lib/JsonRpcAdaptor.h <span style="color: grey">(83836c8)</span></li>
<li>src/context/engines/songkick/JsonQt/lib/JsonRpcAdaptor.cpp <span style="color: grey">(18a1504)</span></li>
<li>src/context/engines/songkick/JsonQt/lib/JsonRpcAdaptorPrivate.h <span style="color: grey">(03c990c)</span></li>
<li>src/context/engines/songkick/JsonQt/lib/JsonRpcAdaptorPrivate.cpp <span style="color: grey">(c8fddb0)</span></li>
<li>src/context/engines/songkick/JsonQt/lib/JsonToProperties.h <span style="color: grey">(f04bd58)</span></li>
<li>src/context/engines/songkick/JsonQt/lib/JsonToProperties.cpp <span style="color: grey">(4859d49)</span></li>
<li>src/context/engines/songkick/JsonQt/lib/JsonToVariant.h <span style="color: grey">(82b62c0)</span></li>
<li>src/context/engines/songkick/JsonQt/lib/JsonToVariant.cpp <span style="color: grey">(323e31a)</span></li>
<li>src/context/engines/songkick/JsonQt/lib/ParseException.h <span style="color: grey">(a942d37)</span></li>
<li>src/context/engines/songkick/JsonQt/lib/ParseException.cpp <span style="color: grey">(c663179)</span></li>
<li>src/context/engines/songkick/JsonQt/lib/VariantToJson.h <span style="color: grey">(2a1a645)</span></li>
<li>src/context/engines/songkick/JsonQt/lib/VariantToJson.cpp <span style="color: grey">(baa7cdd)</span></li>
<li>src/context/engines/songkick/JsonQt/tests/CMakeLists.txt <span style="color: grey">(4954fe7)</span></li>
<li>src/context/engines/songkick/JsonQt/tests/JsonRpc.cpp <span style="color: grey">(1ce4c9c)</span></li>
<li>src/context/engines/songkick/JsonQt/tests/JsonRpcAdaptor.cpp <span style="color: grey">(6e99599)</span></li>
<li>src/context/engines/songkick/JsonQt/tests/JsonToProperties.cpp <span style="color: grey">(e1a0707)</span></li>
<li>src/context/engines/songkick/JsonQt/tests/JsonToVariant.cpp <span style="color: grey">(414d1c9)</span></li>
<li>src/context/engines/songkick/JsonQt/tests/VariantToJson.cpp <span style="color: grey">(dfad043)</span></li>
<li>src/core-impl/collections/CMakeLists.txt <span style="color: grey">(79046d6)</span></li>
<li>src/core-impl/collections/playdarcollection/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/playdarcollection/PlaydarCollection.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/playdarcollection/PlaydarCollection.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/playdarcollection/PlaydarMeta.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/playdarcollection/PlaydarMeta.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/playdarcollection/PlaydarQueryMaker.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/playdarcollection/PlaydarQueryMaker.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/playdarcollection/amarok_collection-playdarcollection.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/playdarcollection/support/Controller.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/playdarcollection/support/Controller.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/playdarcollection/support/ProxyResolver.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/playdarcollection/support/ProxyResolver.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/playdarcollection/support/QMFunctionTypes.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/playdarcollection/support/Query.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/playdarcollection/support/Query.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/core-impl/collections/support/MemoryFilter.cpp <span style="color: grey">(e329faa)</span></li>
<li>src/core-impl/collections/support/MemoryQueryMaker.cpp <span style="color: grey">(831601b)</span></li>
<li>src/core-impl/meta/proxy/MetaProxy.cpp <span style="color: grey">(341e076)</span></li>
<li>src/core-impl/meta/proxy/MetaProxy_p.h <span style="color: grey">(d2638a8)</span></li>
<li>src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp <span style="color: grey">(592bc24)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100001/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100001/s/2/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2010/09/24/ss-amarok-defaultPlaylistAndCoversLoaded_400x100.png" style="border: 1px black solid;" alt="It works! (for me)" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>