<div class="gmail_quote">2009/9/29 Seb Ruiz <span dir="ltr"><<a href="mailto:ruiz@kde.org">ruiz@kde.org</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Hi Valentin,<br>
Do we need to add this extra button here? IIRC, we never had a "cancel<br>
lyrics edit" button in 1.4, and it was never requested either which<br>
leads me to believe that it really isn't so necessary. If you make an<br>
editing mistake, then just refetch the lyrics from the server.<br></blockquote><div><br></div><div>I guess it is possible to live without it, but here's a case where refetching is not a good solution : you already have edited your lyrics, then edit them again, and not want to save your new changes. In that case refetching lyrics will just make you lose what you had done before.</div>
<div>Also, you may want to edit lyrics when not connected to internet, and then refetching won't work.</div><div>And last one, as you can cancel when editing lyrics in the edit tags dialog, I think it makes sense to be able to do it as well in the applet.</div>
<div><br></div><div>But of course if nobody else feels the need for that button, we could revert my commit</div></div>