<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0">
</HEAD>
<BODY>
Hi Nikolaj,<BR>
<BR>
thank you very much for comments.<BR>
<BR>
Regarding:<BR>
<BR>
- significant clipping - please pull new svn version of phonon - I've fixed this issue already. Please use svn - it's not yet in git. I've sent a message to this list with announcement.<BR>
And yes the sound is now much much better - 99.999% compatible with Audacious so it'll leave xine behind IMHO. I wouldn't worry about ranges - because this equalizer code have<BR>
nothing to do with the xine.<BR>
- "[...] Also, we obviously need a dialog for manually configuring levels [...]" - well I don't understand what you mean by that exactly. If you navigate to settings->configuration->playback you'll find<BR>
an equalizer configuration box where you can change/save/delete presets manually.<BR>
- Regarding whatever the action menu with preset list should be under settings or tools is open - let's users decide :)<BR>
<BR>
So please update your phonon,then use a configuration / playback dialog and let me know whatever you like it ...<BR>
<BR>
Best regards<BR>
<BR>
Artur <BR>
<BR>
Dnia 2009-07-20, pon o godzinie 20:39 +0200, Nikolaj Hald Nielsen pisze:<BR>
<BLOCKQUOTE TYPE=CITE>
Hi Artur.<BR>
<BR>
I finally managed to get Amarok to play sounds again so I could actually test your patch.<BR>
<BR>
First of all: wow, well done, it actually works! :-)<BR>
<BR>
I have a few comments:<BR>
<BR>
I don't know if this belongs in the settings menu, I am thinking it would fit better under "tools", but this is up for discussion. Also, we obviously need a dialog for manually configuring levels. And then people would likely want to be able to save their own custom presets as well, so there are a lot of things to disuss and work on here! :-)<BR>
<BR>
And then, as you yourself mention, there are some pretty significant clipping in both the trebble especially the bass in some of the presets. I am thinking that it might make sense to perhaps limit the range a little, as it seems like we are really going beyound xines abilities with some settings?<BR>
<BR>
Anyway, keep up the good work, many people will be very happy to get this feature back!<BR>
<BR>
- Nikolaj<BR>
<BR>
</BLOCKQUOTE>
\<BR>
<TABLE CELLSPACING="0" CELLPADDING="0" WIDTH="100%">
<TR>
<TD>
Omnes Vulnerant Postuma Necat ...<BR>
--------------------------------------------------------------------------<BR>
Registered User No 397465<BR>
GNU/Linux Linux 2.6.28-12-generic x86_64<BR>
(K)/(U)buntu 9.04<BR>
--------------------------------------------------------------------------<BR>
<BR>
<BR>
</TD>
</TR>
</TABLE>
</BODY>
</HTML>