I don't think the patch would work for most cases since many people have tracks with non-UTF-8 encoding and yet UTF-8 locale for their system.<br><br>I wonder if we should check the encoding by looking up the encoding table provide by QT(<a href="http://doc.trolltech.com/4.3/qtextcodec.html">http://doc.trolltech.com/4.3/qtextcodec.html</a>). If you think this is yet too complicated, how about just let the users to set their default encoding if it is not UTF-8.<br>
<br><div class="gmail_quote">On Sun, Apr 20, 2008 at 10:57 PM, Scott Wheeler <<a href="mailto:wheeler@kde.org">wheeler@kde.org</a>> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Jeff Mitchell wrote:<br>
> Totally reasonable, but I believe, if my assumption is correct, that this may<br>
> be a better fix to put into taglib. My assumption is that the strings we get<br>
> from taglib are supposed to be UTF-8...if that's the case, taglib should be<br>
> doing this conversion...if that's not the case, we should consider doing it<br>
> ourselves with your patch. [...]<br>
<br>
This is the classical case of MP3s containing incorrect info. The<br>
reason that a patch like this can't go directly into TagLib is that<br>
TagLib doesn't link against Qt and as such doesn't have the huge tables<br>
of encodings that Qt does.<br>
<br>
-Scott<br>
_______________________________________________<br>
Amarok-devel mailing list<br>
<a href="mailto:Amarok-devel@kde.org">Amarok-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/amarok-devel" target="_blank">https://mail.kde.org/mailman/listinfo/amarok-devel</a><br>
</blockquote></div><br><br clear="all"><br>-- <br>Peter<br>-------------------------------<br><a href="http://www.peterzl.net/">http://www.peterzl.net/</a>