I am assuming that a .pls file is a playlist file which contains multiple urls for the stream.<br>The Amarok 1.x behaviour to show multiple tracks in the playlist on loading a pls file for a stream<br>is a bit ugly imo. We might be able to create MetaStream instance from a pls file directly, which could
<br>then select the stream to play internally, although i'm not quite sure how do that yet.<br>maybe we could add a special case in the enginecontroller which would then try to play the other stream urls if the engine fails to play the first one, although i'm not really happy with that solution.
<br><br>I agree it' not an issue now, because we can't load pls playlists yet, but when we implement that, we have to retrieve the new metadata for the stream from the engine periodically. only MetaStream does that at the moment, and i don't think we need that capability in any other class. Does it make sense to change the service infrastrructure so that it's able to handle Meta::Track instances which are not ServiceTracks?
<br><br>Max<br><br><div><span class="gmail_quote">On 9/10/07, <b class="gmail_sendername">Nikolaj Hald Nielsen</b> <<a href="mailto:nhnfreespirit@gmail.com">nhnfreespirit@gmail.com</a>> wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Right now I am not sure this is even an issue, as the streams are in<br>the form of a .pls file that the playlist currently cannot even<br>accept. Will the playlist loader not take care of this conversion?<br><br>On 9/10/07, Maximilian Kossick <
<a href="mailto:maximilian.kossick@googlemail.com">maximilian.kossick@googlemail.com</a>> wrote:<br>> Nikolaj, I just noticed: because the shoutcast service operates on radio<br>> streams instead of streams of a single track, you should use
<br>> the stream classes provided in meta/stream instead of your ServieTrack<br>> classes. MetaStream updates itself whenever the engine provides new metadata<br>> for the stream.<br>><br>><br>> On 9/10/07, Nikolaj Hald Nielsen <
<a href="mailto:nhnFreespirit@gmail.com">nhnFreespirit@gmail.com</a>> wrote:<br>> > SVN commit 710526 by nhnielsen:<br>> ><br>> > base ShoutcastServiceQueryMaker on the new DynamicServiceQueryMaker class
<br>> ><br>> > M +1 -1 ShoutcastServiceQueryMaker.cpp<br>> > M +7 -42 ShoutcastServiceQueryMaker.h<br>> ><br>> ><br>> > ---<br>> trunk/extragear/multimedia/amarok/src/servicebrowser/shoutcast/ShoutcastServiceQueryMaker.cpp
<br>> #710525:710526<br>> > @@ -42,7 +42,7 @@<br>> ><br>> ><br>> > ShoutcastServiceQueryMaker::ShoutcastServiceQueryMaker(<br>> ShoutcastServiceCollection * collection )<br>> > - : QueryMaker()
<br>> > + : DynamicServiceQueryMaker()<br>> > , m_storedTransferJob( 0 )<br>> > , d( new Private )<br>> ><br>> > ---<br>> trunk/extragear/multimedia/amarok/src/servicebrowser/shoutcast/ShoutcastServiceQueryMaker.h
<br>> #710525:710526<br>> > @@ -17,10 +17,10 @@<br>> > * 51 Franklin Street, Fifth Floor, Boston, MA 02111-1307, USA.<br>> *<br>> ><br>> ***************************************************************************/
<br>> ><br>> > -#ifndef DYNAMICSERVICEQUERYMAKER_H<br>> > -#define DYNAMICSERVICEQUERYMAKER_H<br>> > +#ifndef SHOUTCASTSERVICEQUERYMAKER_H<br>> > +#define SHOUTCASTSERVICEQUERYMAKER_H<br>> >
<br>> > -#include "QueryMaker.h"<br>> > +#include "DynamicServiceQueryMaker.h"<br>> ><br>> > #include "meta.h"<br>> ><br>> > @@ -39,7 +39,7 @@<br>> >
<br>> > @author<br>> > */<br>> > -class ShoutcastServiceQueryMaker : public QueryMaker<br>> > +class ShoutcastServiceQueryMaker : public DynamicServiceQueryMaker<br>> > {<br>> > Q_OBJECT
<br>> > public:<br>> > @@ -53,9 +53,11 @@<br>> > virtual QueryMaker* startTrackQuery();<br>> > virtual QueryMaker* startGenreQuery();<br>> ><br>> > -<br>> > virtual QueryMaker* addMatch ( const Meta::GenrePtr &genre );
<br>> > + virtual QueryMaker* addMatch ( const Meta::DataPtr &data );<br>> ><br>> > + virtual QueryMaker* returnResultAsDataPtrs ( bool resultAsDataPtrs );<br>> > +<br>> > //Methods "borrowed" from MemoryQueryMaker
<br>> > void runQuery();<br>> > void handleResult();<br>> > @@ -65,43 +67,6 @@<br>> > void fetchGenres();<br>> ><br>> ><br>> > -<br>> > - //currently unimplemented stuff:
<br>> > -<br>> > - //as this particular QueryMaker ronly knows about genres and tracks,<br>> all the other stuuf is kinda overkill!!<br>> > -<br>> > - virtual QueryMaker* startComposerQuery() { return this; }
<br>> > -<br>> > - virtual QueryMaker* startArtistQuery() { return this; }<br>> > - virtual QueryMaker* startAlbumQuery() { return this; }<br>> > - virtual QueryMaker* startYearQuery() { return this; }
<br>> > - virtual QueryMaker* startCustomQuery() { return this; }<br>> > -<br>> > - virtual QueryMaker* returnResultAsDataPtrs ( bool resultAsDataPtrs );<br>> > - virtual QueryMaker* addReturnValue ( qint64 value ) { return this; }
<br>> > - virtual QueryMaker* orderBy ( qint64 value, bool descending = false )<br>> { return this; }<br>> > -<br>> > - virtual QueryMaker* includeCollection ( const QString &collectionId )<br>
> { return this; }<br>> > - virtual QueryMaker* excludeCollection ( const QString &collectionId )<br>> { return this; }<br>> > -<br>> > -<br>> > - virtual QueryMaker* addMatch ( const Meta::TrackPtr &track ) { return
<br>> this; }<br>> > - virtual QueryMaker* addMatch ( const Meta::ArtistPtr &artist ) {<br>> return this; }<br>> > - virtual QueryMaker* addMatch ( const Meta::AlbumPtr &album ) { return<br>
> this; }<br>> > - virtual QueryMaker* addMatch ( const Meta::ComposerPtr &composer ) {<br>> return this; }<br>> > - virtual QueryMaker* addMatch ( const Meta::YearPtr &year ) { return<br>> this; }
<br>> > - virtual QueryMaker* addMatch ( const Meta::DataPtr &data );<br>> > -<br>> > - virtual QueryMaker* addFilter ( qint64 value, const QString &filter,<br>> bool matchBegin, bool matchEnd ) { return this; }
<br>> > - virtual QueryMaker* excludeFilter ( qint64 value, const QString<br>> &filter, bool matchBegin, bool matchEnd ) { return this; }<br>> > -<br>> > - virtual QueryMaker* limitMaxResultSize ( int size ) { return this; }
<br>> > -<br>> > - virtual QueryMaker* beginAnd() { return this; }<br>> > - virtual QueryMaker* beginOr() { return this; }<br>> > - virtual QueryMaker* endAndOr() { return this; }<br>> > -
<br>> > -<br>> > signals:<br>> > void dynamicQueryComplete();<br>> ><br>> ><br>><br>><br></blockquote></div><br>