<br><br><div><span class="gmail_quote">On 8/1/07, <b class="gmail_sendername">Maximilian Kossick</b> <<a href="mailto:mkossick@gmx.de">mkossick@gmx.de</a>> wrote:</span><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
Hi<br>i've been wondering for a few days why the svgs for our new plasma applets do<br>not work for me, and today i was able to figure it out:<br>cmake installs them to desktoptheme/amarok-default/widgets, but plasma looks
<br>for them in desktoptheme/default/widgets, unless one edits plasmarc and adds<br>an entry which points amarok's embedded plasma at the new directory.<br><br>The problem is that the svgs do not work unless one edits plasmarc, which is
<br>clearly unacceptable. Additionally, we won't be able to add our applets to<br>the kde4 desktop if we store the svgs in our own theme directory.</blockquote><div><br><br>Yes, this is how it currently works. I am discussing this method with panel-devel ( i sent them an email yesterday regarding this issue ). It appears aseigo has no particular qualms to changing the current method.
</div><br><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
Afaict the code in Plasma::Theme seems to be all or nothing: either the image<br>or svg is part of the current theme, or it is not: what happens if somebody<br>changes the theme of the kde4 desktop and wants to add amarok applets to it?
<br>At the moment it won't load the applets at all, but doesn't it make more<br>sense to degrade gracefully, e.g. use images/svgs from the default theme<br>instead of not loading them at all? </blockquote><br><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
Leo, is there a particular reason that you put the svgs into their own theme<br>directory instead of just installing them in the default plasma theme? And do<br>you know if the plasma guys have a plan for handling incomplete themes?
</blockquote><div><br>We cannot simply install our svgs into the default plasma theme, because some names conflict. We could, i guess, prefix all amarok svg names in order to namespace them. But I do not see why we *should* install our theme to the global desktoptheme/.
<br> <br>Regardless of where we install our default theme, we want to be able to control the theme selection in amarokrc, not in plasmarc, so I'll follow up on that on panel-devel.<br><br>leo<br> </div><br><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
Cheers, Max<br><br>_______________________________________________<br>Amarok-devel mailing list<br><a href="mailto:Amarok-devel@kde.org">Amarok-devel@kde.org</a><br><a href="https://mail.kde.org/mailman/listinfo/amarok-devel">
https://mail.kde.org/mailman/listinfo/amarok-devel</a><br><br><br></blockquote></div><br><br clear="all"><br>-- <br>______________________________________________________<br>Leo Franchi <a href="mailto:angel666@myrealbox.com">
angel666@myrealbox.com</a><br>4305 Charlemagne Ct <a href="mailto:lfranchi@gmail.com">lfranchi@gmail.com</a> <br>Austin cell: (650) 704 3680<br>TX, USA home: (650) 329 0125