<span class="gmail_quote">On 7/17/07, <b class="gmail_sendername">Aaron J. Seigo</b> <<a href="mailto:aseigo@kde.org">aseigo@kde.org</a>> wrote:</span><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
On Monday 16 July 2007, Leo Franchi wrote:<br>> On 7/16/07, Aaron J. Seigo <<a href="mailto:aseigo@kde.org">aseigo@kde.org</a>> wrote:<br>> > shoot anyone if there a few extra spaces here and there, but it would be
<br>> > nice<br>> > to follow things as closely as possible.<br>><br>> sorry about that. i tried to figure out if there was a consistent<br>> coding convention (especially for spaces inside parenthesis) but it
<br>> seemed like it was pretty even between<br>> spaces-between-parens and no spaces. as Amarok code uses spaces, that<br><br>it's mostly my fault. we started with the same style i used in kicker, then<br>moved to the kdelibs style when it arrived, and then i realized that the
<br>kdelibs style does not do spaces within ()s. so... yeah. we went through one<br>major and one minor revolution already. mix in some deviations here and there<br>from various committers that innevitably slip in and i can see how it would
<br>be easy to get mistaken here.<br><br>> > - why do you need the list of loaded applets from Corona<br>> > (loadedApplets())?<br>> > (not saying it's not valid, just wondering what the use case is)
<br>><br>> this is so there is a way to clear the corona. as applets are started<br>> by the user, currently from the controlbox, the contextscene (corona<br>> subclass) needs to know what is on<br>> the corona itself so it can a) save the state b) clear it c) set next
<br>> state. as the user plays a track, for example, the corona should clear<br>> the "home" state and display context-<br>> relative information. this is all done in the subclassed ContextScene, but<br>
> as the applet list is in the dptr, it needs access to it.<br><br>ah! ok.. this makes things much clearer. i was just about to add a<br>clearApplets() method to Corona, but figured i might end up causing you some<br>conflicts doing that.. so i'll add it after you commit your patch, unless you
<br>add it to your patch. that should take care of one of the use cases..<br><br>the other one, switching layouts, is very interesting. Alexis has just started<br>working on saving/restoring applet locations and one of the eventual goals
<br>has always been to allow one to save/restore layouts at runtime by passing in<br>a different configuration. so perhaps you may not need access to the applets<br>themselves directly ... i'm ok with keeping the loadedApplets() method there
<br>(it might be useful for someone and can get you guys going in the meantime)<br>but i'm glad i know the use case you have now so we can work towards<br>supporting that sooner...</blockquote><div><br>ah... thats interesting. i'll wait and see what comes out of the work on saving/restoring sessions.
</div><br><br><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
i also assume that context menus will become an issue.<br>Corona::contextMenuEvent will be problematic for amarok, i assume. in fact,<br>it's already going to be an issue for plasma with panels. i'll look into a<br>
solution for that here...</blockquote><div><br>yeah, i had kind of ignored that issue. </div><br><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
> > for the time being until someone comes up with a good reason for why they<br>> > need their own svg theme but not applets, or vice versa<br>><br>> ok, i don't really know much about krunner so i had no idea of the
<br>> repercussions of that change :)<br><br>that's why we do peer review =)<br><br>> tomorrow i'll fix up the patch and look to doing things how you have<br>> suggested.<br><br>great =) i'm sure we'll get your patch in within the next day or so.
</blockquote><div><br><br>ok, i attach the new patch. a few things: first of all, i did things the "first way" that you talked about, using a global prefix variable with getters/setters, instead of a global KTrader namespace with more constraints. the reason is this: in order to add more constraints we would need to add more getters
<br>and setters to each individual class that needs them, because we can't re-implement functions that call data in the dptrs. this is nevertheless probably a good thing to discuss in the future and can be resolved with some coordination. for now, though, this should work.
<br><br>also, i first had a static variable with the serviceType in the Applet class (as well as DataEngineManager) but that wouldn't work because if the client app chooses to change<br>the prefix, the variable would still have the old value. what was happening was the value was being initialized before the prefix setter was called. this way, it looks up
<br>the prefix on every query.... which might not be ideal performance wise, but i'm not sure of any other simple way to do it. </div><br><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
p.s. i see in the commit digest the amarok peeps were trying to get a hold of<br>me. irc isn't the most reliable mode for me these days, but email tends to<br>work just fine =)</blockquote><div><br>IRC isn't ideal for me either (at least for a while) as i'm still on vacation in europe and on dialup, so am rarely online. lets keep to email :)
</div><br><br>cheers,<br>leo<br><blockquote class="gmail_quote" style="margin-top: 0; margin-right: 0; margin-bottom: 0; margin-left: 0; margin-left: 0.80ex; border-left-color: #cccccc; border-left-width: 1px; border-left-style: solid; padding-left: 1ex">
--<br>Aaron J. Seigo<br>humru othro a kohnu se<br>GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43<br><br>KDE core developer sponsored by Trolltech<br><br>_______________________________________________
<br>Amarok-devel mailing list<br><a href="mailto:Amarok-devel@kde.org">Amarok-devel@kde.org</a><br><a href="https://mail.kde.org/mailman/listinfo/amarok-devel">https://mail.kde.org/mailman/listinfo/amarok-devel</a><br><br>
<br></blockquote><br><br clear="all"><br>-- <br>______________________________________________________<br>Leo Franchi <a href="mailto:angel666@myrealbox.com">angel666@myrealbox.com</a><br>4305 Charlemagne Ct
<a href="mailto:lfranchi@gmail.com">lfranchi@gmail.com</a> <br>Austin cell: (650) 704 3680<br>TX, USA home: (650) 329 0125