D28165: Fix compatibility with modern MySQL

Andreas Sturmlechner noreply at phabricator.kde.org
Wed Mar 25 01:15:54 GMT 2020


asturmlechner added a comment.


  In D28165#633145 <https://phabricator.kde.org/D28165#633145>, @wbauer wrote:
  
  > The content of my /usr/include/mysql/mysql_version.h (which is just a symlink to mariadb_version.h):
  
  
  I just went back and installed mariadb-connector-c in Gentoo in mysqlcompat-mode (a soon to be removed option) and interestingly, it does not provide that symlink. Just something to take into account when using that header, I don't know how consistent other distros are doing this.
  
  Locally though I have already been toying around with separate MySQL/MariaDB support so I could then probably amend that with another ifdef.

INLINE COMMENTS

> CMakeLists.txt:3
> +if( BUILD_MYSQLE_COLLECTION )
> +       add_subdirectory( db/sql )
> +endif()

amarok cmake files seem to be using a tab size of 4 spaces fairly consistently, please keep it that way

REPOSITORY
  R181 Amarok

REVISION DETAIL
  https://phabricator.kde.org/D28165

To: vmatare
Cc: jfowkes, asturmlechner, wbauer, amarok-devel, pgomes, nicolamori, jyasi, mfraser, ryanmccoskrie, semareit, eridani, eoinoneill, jackyalcine, nhuisman, paul, domson, yaohanchen, malteveerman, markey, James, tbettler, Smar, ricktimmis, schweingruber, heikobecker
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20200325/49e783db/attachment.html>


More information about the Amarok-devel mailing list