D27369: Fix loading of lyrics from lyrics.wikia.com

Pedro Gomes noreply at phabricator.kde.org
Thu Feb 13 14:05:15 GMT 2020


pgomes created this revision.
pgomes added a reviewer: schweingruber.
pgomes created this object with edit policy "Administrators".
pgomes added a project: Amarok.
Herald added subscribers: amarok-devel, Amarok.
Herald removed a project: Amarok.
pgomes requested review of this revision.

REVISION SUMMARY
  Fix error where Amarok failed to load lyrics from lyrics.wikia.com because the domain was being redirected to lyrics.fandom.com.
  
  KDE Bugtracking System: https://bugs.kde.org/show_bug.cgi?id=417259
  
  The fix does two things:
  
  - update the base API Url to the redirected domain lyrics.fandom.com, thus skipping the redirection
  - makes LyricsManager react to possible future redirections

REPOSITORY
  R181 Amarok

REVISION DETAIL
  https://phabricator.kde.org/D27369

AFFECTED FILES
  src/lyrics/LyricsManager.cpp
  src/lyrics/LyricsManager.h

To: pgomes, schweingruber
Cc: #amarok, pgomes, amarok-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20200213/1a29d505/attachment.html>


More information about the Amarok-devel mailing list