D28593: Fix copying and moving files to collection

[Pedro Gomes]

pgomes created this revision.
pgomes added reviewers: Amarok, amarok-devel.
pgomes created this object with edit policy "Administrators".
pgomes added projects: Amarok, Qt 5 Porting.
pgomes requested review of this revision.

REVISION SUMMARY
  The importation of files to collections was not working. Both because its dialogs were crashing and because the copying method was wrong. This patch does the following:
  
  - fix the crash of confirmation dialog when either accepting or rejecting the import. The crash was caused because a "detroyed" signal was being used at a chain of deleted widgets, eventually causing a crash signal
  - fix the file copying (SqlCollectionLocation.cpp). The code was using a QURL (with the "file:///" scheme) to locate the destination, and thus failing to find the destination dir
  - fix the layout of Transcoding dialog. Before the buttonbox was doubled, and only the KPageDialog was being show. And was overlapped by another widget
  - fix the layout of the importation configuration menu (OrganizeCollectionDialog). Before the QDialog didn't have a layout, and resizing the window was not resizing widgets
  - restore the importation menu to "Copy to Collection". Before only "Move to Collection" was popping up an importation dialog. The reason was a wrong connection of signals

REPOSITORY
  R181 Amarok

REVISION DETAIL
  https://phabricator.kde.org/D28593

AFFECTED FILES
  src/browsers/filebrowser/FileView.cpp
  src/core-impl/collections/db/sql/SqlCollectionLocation.cpp
  src/dialogs/OrganizeCollectionDialog.cpp
  src/transcoding/TranscodingAssistantDialog.cpp
  src/transcoding/TranscodingAssistantDialog.ui
  src/transcoding/TranscodingPropertySliderWidget.cpp
  src/widgets/TokenDropTarget.cpp

To: pgomes, #amarok, amarok-devel
Cc: amarok-devel, #amarok, pgomes, nicolamori, jyasi, mfraser, ryanmccoskrie, semareit, eridani, eoinoneill, jackyalcine, nhuisman, paul, domson, yaohanchen, malteveerman, markey, James, tbettler, Smar, ricktimmis, asturmlechner, schweingruber, heikobecker
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20200405/0e4e7512/attachment.html>