Bug 184325 - amarok wish: fetch lyrics from the ID3 lyrics tag

[Myriam Schweingruber]

Hi all,

On Wed, Jan 28, 2015 at 4:40 AM, Be <be.0 at gmx.com> wrote:

> On 01/05/2015 08:39 AM, Anmol Ahuja wrote:
> > As of current git, the scripting interface exposes lyrics tags with
> > other embedded metadata, and the default lyrics script already reads
> > and writes lyrics to tracks' lyrics tags.
>
> This does not work for me. Inserting Amarok.debug(embeddedLyrics); in
> this function in the Lyricwiki script prints an empty line in the
> debugging output even if there is a lyrics tag in the file and there are
> lyrics in Amarok's database.
>
> function readEmbeddedLyrics()
> {
>     var track = Amarok.Engine.currentTrack();
>     var embeddedLyrics = track.tags["lyrics"];
>     if( embeddedLyrics != undefined && embeddedLyrics !== "" )
>     {
>         Amarok.debug( "Using embedded lyrics for track \"" + track.title
> + "\"" );
>         Amarok.Lyrics.showLyricsHtml( embeddedLyrics );
>         return true;
>     }
>     return false;
> }
>
>
> Anmol, if you talk about "current git", I presume you mean your repo,
right? IIRC this was not merged to git master yet.

Be: please check Anmol's repository, or even better, check the review
requests located here:
https://git.reviewboard.kde.org/dashboard/?group=amarok


Regards, Myriam

-- 
Proud member of the Amarok and KDE Community
Protect your freedom and join the Fellowship of FSFE:
http://www.fsfe.org
<http://www.fsfe.org>
Please don't send me proprietary file formats,
use ISO standard ODF instead (ISO/IEC 26300)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20150128/1f541e2d/attachment.html>