Tidying up password storage in Amarok

Matěj Laitl matej at laitl.cz
Fri Apr 13 09:13:07 UTC 2012


On 13. 4. 2012 Bart Cerneels wrote:
> > > Incidentally the MySQL configuration interface is implemented using
> > > KConfigXT (an xml file which is translated to c++, which then writes to
> > > plaintext, if I've understood it correctly), i.e. the settings aren't
> > > stored in KWallet. I'll look into whether that can be changed when I'm
> > > migrating the plugins to use PasswordManager.
> > 
> > You're right. I think that it suffices to score just the database login
> > name and password in KWallet, other options should be left in KConfigXT.
> 
> I don't think it's really needed to move that to KWallet.

What do you mean by "that" here? Login name? Database name? Database password?

> People using
> an external mysql server know how to set a unique name for their own
> local database. I'm not aware of any complaints about that. Even there
> wouldbe, I can't justify raising code complexity for it. If you want
> to change this, do it in a separate patch after the main one is
> accepted.

	Matěj


More information about the Amarok-devel mailing list