Review Request: Diagnostics Dialog for Amarok.

Commit Hook null at kde.org
Tue Apr 3 18:51:30 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104449/#review12140
-----------------------------------------------------------


This review has been submitted with commit ce15c154eb7f641c3ce6a273660edb11a2bdcab1 by Andrzej J. R. Hunt to branch master.

- Commit Hook


On April 2, 2012, 1:37 p.m., Andrzej Hunt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104449/
> -----------------------------------------------------------
> 
> (Updated April 2, 2012, 1:37 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Adds a diagnostics dialog to Amarok. This shows versions for KDE, QT, Phonon, the Phonon backend, and all scripts and plugins.
> 
> As described in https://bugs.kde.org/show_bug.cgi?id=296415.
> 
> This patch also changes/corrects PluginManager::plugins() to be const.
> 
> 
> This addresses bug 296415.
>     https://bugs.kde.org/show_bug.cgi?id=296415
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 6e590e8 
>   src/MainWindow.h b149cb9 
>   src/MainWindow.cpp 98b1c77 
>   src/PluginManager.h 6b9f3ca 
>   src/PluginManager.cpp c46b12f 
>   src/dialogs/DiagnosticDialog.h PRE-CREATION 
>   src/dialogs/DiagnosticDialog.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104449/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Screenshot of Dialog
>   http://git.reviewboard.kde.org/r/104449/s/501/
> Updated Screenshot (Version 2)
>   http://git.reviewboard.kde.org/r/104449/s/502/
> 
> 
> Thanks,
> 
> Andrzej Hunt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120403/ae2f8001/attachment.html>


More information about the Amarok-devel mailing list