Review Request: RFC patch: distinguish between mp4, m4a, m4v types in Amarok::FileType

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104481/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

RFC patch: distinguish between mp4, m4a, m4v types in Amarok::FileType

iPod Collection (the new one) needs to distinguish somehow between
MPEG-4 audio and video files; to make this generic, least bad approach
it probably to use Meta::Track:type().

MetaFile::Track's type() is okay, as it just returns lowercased file
extension. SqlTrack stores file type in db as numeric index to the
Amarok::FileType enum, which currently has just one generic entry for
MP4 files.

This patch extends Amarok::FileType with M4a and M4v values and
TagHelper to try to detect more specific MP4 file format. (currently
just file extension based, can be extended in future) Users will need
to do a full rescan for Local Collection to pick up more specialised
file types.

I'm running this through review board as there seems no general
agreement on Meta::Track:type() semantics. (Speaking of which, I'd be
most satisfied if it returned (the most specific) mime-type represented
using dedicated class that would support mimetype hierarchy)

BUG: 268238
FIXED-IN: 2.6
REVIEW: 104481


This addresses bug 268238.
    https://bugs.kde.org/show_bug.cgi?id=268238


Diffs
-----

  ChangeLog 4978be6074c5e9857085bc9b6170b9becde485a6 
  shared/FileType.h 5c8081fa10fe227855a8de6a31fca17ebac5f0e5 
  shared/FileType.cpp a6e25d5661dc60c40cd78a933c2697e26d4e8f64 
  shared/tag_helpers/TagHelper.cpp 4c0fb2b0e6361ead03d2b569499d6828858b1c67 

Diff: http://git.reviewboard.kde.org/r/104481/diff/


Testing
-------


Thanks,

Matěj Laitl

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120403/1b6db379/attachment.html>