Review Request: Add a CMake switch for building playground

Martin Blumenstingl darklight.xdarklight at googlemail.com
Sun Jul 24 20:29:07 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102077/
-----------------------------------------------------------

Review request for Amarok.


Summary
-------

It seems that up to now everyone who tried to build playground had to do evil workarounds.

Since CMake is quite nice I wrote a small fix for it.
It's now possible to enable/disable building playground via a small CMake switch.
By default this switch is set to OFF.


Diffs
-----

  CMakeLists.txt 0c2e958 
  playground/CMakeLists.txt 4cd4052 

Diff: http://git.reviewboard.kde.org/r/102077/diff


Testing
-------

The coverbling applet installs successful if playground is enabled.
I did not test anything else (except disabling the switch again and seeing if the coverbling applet is now excluded).


Thanks,

Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110724/92d736b9/attachment.htm 


More information about the Amarok-devel mailing list