Review Request: Partial Rewrite of ID3v2TagHelper.cpp

Stefan Derkits stefan at derkits.at
Fri Jul 22 22:53:21 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102055/
-----------------------------------------------------------

Review request for Amarok and Ralf Engels.


Summary
-------

Rewrite if else else if Constructs to switch statements

Add common Frame Names to m_fieldMap


Diffs
-----

  shared/tag_helpers/ID3v2TagHelper.cpp 27e0cf0a9f6dc0bfbbd54cab65cb65dd6bef8a33 

Diff: http://git.reviewboard.kde.org/r/102055/diff


Testing
-------

not much ... ;)


Thanks,

Stefan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110722/1105ce28/attachment.htm 


More information about the Amarok-devel mailing list