Review Request: Implements a preview button in the collection organizer dialog along with an "automatic preview" checkbox

Maximilian Güntner maximilian.guentner at gmail.com
Fri Jan 21 00:00:19 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100270/
-----------------------------------------------------------

(Updated Jan. 20, 2011, 11 p.m.)


Review request for Amarok.


Changes
-------

Rewrite of my previous patch. I've replaced the SignalMapper with the more elegant sender() function.


Summary
-------

This patch adds manual preview functionality to the collection organizer dialog. This is very handy when altering the filename scheme and options of large collections ( > 1k files) since the dialog doesn't update the preview widget with every change in the filename configurator. The current functionality can be achieved by clicking on "Automatic Preview". Hope you like it.


Diffs (updated)
-----

  src/dialogs/OrganizeCollectionDialog.cpp a104c8e 
  src/dialogs/OrganizeCollectionDialogBase.ui 2f28102 

Diff: http://git.reviewboard.kde.org/r/100270/diff


Testing
-------

-tested auto update by using/clicking each element that connects to the signalmapper
-tested the manual preview button
-moved a collection


Screenshots
-----------

Preview Button and auto preview checkbox
  http://git.reviewboard.kde.org/r/100270/s/31/


Thanks,

Maximilian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110120/f2cbe10a/attachment.htm 


More information about the Amarok-devel mailing list