Review Request: Remove FFmpeg dependencies from the new MusicBrainz fingerprinting by using Phonon::AudioDataOutput instead of FFmpeg directly

Kevin Kofler kevin.kofler at chello.at
Mon Oct 4 01:07:03 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100021/
-----------------------------------------------------------

Review request for amarok.


Summary
-------

This patch removes FFmpeg dependencies from the new MusicBrainz fingerprinting by using Phonon::AudioDataOutput instead of FFmpeg directly.

WARNING: This version of the patch is completely untested and may not even build.
In addition, Phonon::AudioDataOutput may not be ready for production use yet (crashes, decoding speed issues).
You have been warned.


Diffs
-----

  CMakeLists.txt baacef5 
  src/musicbrainz/MusicDNSAudioDecoder.h 97976f6 
  src/musicbrainz/MusicDNSAudioDecoder.cpp eef459a 

Diff: http://git.reviewboard.kde.org/r/100021/diff


Testing
-------

None yet.


Thanks,

Kevin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101003/abe99ad2/attachment.htm 


More information about the Amarok-devel mailing list