Review Request: Added search path in FindFFmpeg.cmake

James Duncan james.t.duncan at gmail.com
Sun Oct 3 21:44:56 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100014/
-----------------------------------------------------------

(Updated 2010-10-03 19:44:55.631794)


Review request for amarok.


Changes
-------

Apparently the include directory was being specified too deeply.
Now, instead of searching for avcodec.h directly, the module
looks for libavcodec/avcodec.h.  This solved the problem in bug
253087.  If someone else could apply this patch and test that
you can still compile, that would be great.


Summary
-------

Added another search path suffix for when CMake is looking for
libavcodec and libavformat.  Also, cleaned up the module a little.


Diffs (updated)
-----

  cmake/modules/FindFFmpeg.cmake 6767d1b 
  src/CMakeLists.txt 07e08b9 

Diff: http://git.reviewboard.kde.org/r/100014/diff


Testing
-------

I can still configure and compile successfully, so this fix should
not affect currently working systems.


Thanks,

James

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101003/63a82d01/attachment-0001.htm 


More information about the Amarok-devel mailing list