[Amarok] 366dbe7 Fix SqlTrack playcount semantics towards LastFM/FM

Jeff Mitchell mitchell at kde.org
Wed Mar 24 17:01:02 CET 2010


On 3/24/2010 11:51 AM, Maximilian Kossick wrote:
> No, I mean changing StatisticsProvider::played( double ) to played(
> double, Meta::TrackPtr )
> 
> and using the track in played() to decide whether the statistics have
> to be updated. You can just pass the length of the track to
> StatisticsProvider::played(), but I like the other solution better

OK. I don't think it really makes a difference, but this at least makes
it a little more future proof if you ever want the statistics to depend
on some other aspect of the track. (And may make it easier to tie in
saving statistics to a track later on.)

--Jeff

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 196 bytes
Desc: OpenPGP digital signature
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20100324/f59ae00f/attachment.sig 


More information about the Amarok-devel mailing list