Fix for outstanding collection browser bug

Ralf Engels ralf-engels at gmx.de
Thu Aug 5 20:43:22 CEST 2010


It seems like I found the reason for at least some of the effects in
https://bugs.kde.org/show_bug.cgi?id=172542

After handling the row moved signal in GroupingProxy everything seems to
work.

Here is the diff. It would be nice if somebody would integrate it.
Also it would be nice if somebody would update Gitourious again so that
people would have an easy way to post merge requests.


diff --git a/src/playlist/proxymodels/GroupingProxy.cpp 
b/src/playlist/proxymodels/GroupingProxy.cpp
index 9bfb930..92a4035 100644
--- a/src/playlist/proxymodels/GroupingProxy.cpp
+++ b/src/playlist/proxymodels/GroupingProxy.cpp
@@ -64,7 +64,7 @@ Playlist::GroupingProxy::GroupingProxy( 
Playlist::AbstractModel *belowModel, QOb
     connect( this, SIGNAL( modelReset() ), this, SLOT( 
proxyModelReset() ) );
     connect( this, SIGNAL( rowsInserted( const QModelIndex&, int,
int ) 
), this, SLOT( proxyRowsInserted( const QModelIndex &, int, int ) ) );
     connect( this, SIGNAL( rowsRemoved( const QModelIndex&, int, int ) 
), this, SLOT( proxyRowsRemoved( const QModelIndex&, int, int ) ) );
-
+    connect( this, SIGNAL( rowsMoved( const QModelIndex &, int, int, 
const QModelIndex &, int) ), this, SLOT( proxyLayoutChanged() ) );
 
     // No need to scan the pre-existing entries in sourceModel(), 
because we build our
     // internal state on-the-fly.




More information about the Amarok-devel mailing list