<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112965/">http://git.reviewboard.kde.org/r/112965/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Bodega.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Oct. 21, 2013, 8:43 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">split the functionality into two routes.
Also with the new route the mocha timeout issue
doesn't occur anymore.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
bodega-server
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a new route which returns the messages from the forum.
The json looks like this
{
"authStatus": true,
"device": "KDE-1",
"store": "KDE-1",
"points": 10000,
"success": true,
"topics": [
{
"title": "Foo bar linux12342425",
"message": "<p>foo bar linux123423235235235</p>"
},
{
"title": "Foo bar linux123424566",
"message": "<p>foo bar linux1234578896666</p>"
},
{
"title": "Foo bar linux1234245",
"message": "<p>foo bar linux12342245</p>"
},
{
"title": "Foo bar linux1234",
"message": "<p>foo bar linux1234566</p>"
},
{
"title": "Foo bar ioanna maria 1foo bar ioanna maria 1adsasd",
"message": "<p>88971238912389()(<em>()DAS</em>()A*(DS()<em>ADS(</em>()ADS908foo bar ioanna maria 1foo bar ioanna maria 1foo bar ioanna maria 1foo bar ioanna maria 1</p>"
}
]
}</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">$ make test/forum
./node_modules/.bin/mocha test/forum.js --reporter spec
WARNING: Setting up server with no ssl!
Bodega server listening on localhost:3001 in devel mode
Forum
Authorization
? succeeds (75ms)
List Messages
? should fail because the asset is invalid
? should succeed (3313ms) <------------------------------------------------------ Probably something is wrong here. It takes 3 seconds and both bodega-server and the forum are in localhost.
I did this.timeout(15000) in order to pass the test
3 passing (3 seconds)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>.gitignore <span style="color: grey">(6b01f0d)</span></li>
<li>README <span style="color: grey">(164e0d8)</span></li>
<li>assetimporters/CMakeLists.txt <span style="color: grey">(369626f)</span></li>
<li>assetimporters/common/database.h <span style="color: grey">(b66c4b2)</span></li>
<li>assetimporters/common/database.cpp <span style="color: grey">(edf8526)</span></li>
<li>assetimporters/projectgutenberg/src/catalog.cpp <span style="color: grey">(e5c8483)</span></li>
<li>assetimporters/projectgutenberg/src/ebook.cpp <span style="color: grey">(2eea13b)</span></li>
<li>assetimporters/projectgutenberg/src/gutenbergdatabase.h <span style="color: grey">(6c7a02c)</span></li>
<li>assetimporters/projectgutenberg/src/gutenbergdatabase.cpp <span style="color: grey">(b8fa3c7)</span></li>
<li>assetimporters/projectgutenberg/src/main.cpp <span style="color: grey">(6ec658b)</span></li>
<li>server/.jshintignore <span style="color: grey">(23ededc)</span></li>
<li>server/Makefile <span style="color: grey">(2f8082d)</span></li>
<li>server/TODO <span style="color: grey">(1a314ba)</span></li>
<li>server/app.js <span style="color: grey">(da49ccb)</span></li>
<li>server/assetRules.js <span style="color: grey">(2dca3ee)</span></li>
<li>server/bodegaDbHelper <span style="color: grey">(759bc82)</span></li>
<li>server/config.json.sample <span style="color: grey">(c691247)</span></li>
<li>server/doc/bodega.json <span style="color: grey">(a08746f)</span></li>
<li>server/lib/assetstore.js <span style="color: grey">(d3f1887)</span></li>
<li>server/lib/bodegadb.js <span style="color: grey">(a1063fe)</span></li>
<li>server/lib/db/assetinfo.js <span style="color: grey">(c365a0d)</span></li>
<li>server/lib/db/assetmanager.js <span style="color: grey">(0532323)</span></li>
<li>server/lib/db/authorize.js <span style="color: grey">(7021c18)</span></li>
<li>server/lib/db/banking.js <span style="color: grey">(87e3825)</span></li>
<li>server/lib/db/changeAccountDetails.js <span style="color: grey">(2bd965c)</span></li>
<li>server/lib/db/channels.js <span style="color: grey">(b5a76ef)</span></li>
<li>server/lib/db/createutils.js <span style="color: grey">(dae5ed3)</span></li>
<li>server/lib/db/deleteasset.js <span style="color: grey">(e73374a)</span></li>
<li>server/lib/db/download.js <span style="color: grey">(91fe9c9)</span></li>
<li>server/lib/db/easterEggHunt.js <span style="color: grey">(a3946ea)</span></li>
<li>server/lib/db/forum.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>server/lib/db/listassets.js <span style="color: grey">(3656657)</span></li>
<li>server/lib/db/partners.js <span style="color: grey">(b767b7d)</span></li>
<li>server/lib/db/partnersrequests.js <span style="color: grey">(918fae9)</span></li>
<li>server/lib/db/points.js <span style="color: grey">(b3c8096)</span></li>
<li>server/lib/db/postasset.js <span style="color: grey">(5a26a80)</span></li>
<li>server/lib/db/publishasset.js <span style="color: grey">(02555d4)</span></li>
<li>server/lib/db/purchaseAsset.js <span style="color: grey">(f39cfed)</span></li>
<li>server/lib/db/ratings.js <span style="color: grey">(95f38c9)</span></li>
<li>server/lib/db/resetrequest.js <span style="color: grey">(681ddf7)</span></li>
<li>server/lib/db/tags.js <span style="color: grey">(6624d0f)</span></li>
<li>server/lib/errors.js <span style="color: grey">(ccf3ebb)</span></li>
<li>server/lib/janitor.js <span style="color: grey">(6e7e2ef)</span></li>
<li>server/lib/messengers/participant_accountActivation.js <span style="color: grey">(9bdad18)</span></li>
<li>server/lib/messengers/participant_passwordReset.js <span style="color: grey">(b94be12)</span></li>
<li>server/lib/messengers/partner_distributorRequest.js <span style="color: grey">(6b6c0f8)</span></li>
<li>server/lib/messengers/partner_distributorRequestAccept.handlebars.text <span style="color: grey">(ce69337)</span></li>
<li>server/lib/messengers/partner_distributorRequestAccept.js <span style="color: grey">(462479f)</span></li>
<li>server/lib/messengers/partner_distributorRequestReject.handlebars.text <span style="color: grey">(a6495e0)</span></li>
<li>server/lib/messengers/partner_distributorRequestReject.js <span style="color: grey">(4c1db67)</span></li>
<li>server/lib/messengers/partner_distributor_assetRejection.handlebars.text <span style="color: grey">(9fc3980)</span></li>
<li>server/lib/messengers/partner_distributor_assetRejection.js <span style="color: grey">(744a23a)</span></li>
<li>server/lib/messengers/partner_publisherRequest.js <span style="color: grey">(4061966)</span></li>
<li>server/lib/messengers/partner_publisherRequestAccept.handlebars.text <span style="color: grey">(b408795)</span></li>
<li>server/lib/messengers/partner_publisherRequestAccept.js <span style="color: grey">(84690ab)</span></li>
<li>server/lib/messengers/partner_publisherRequestReject.handlebars.text <span style="color: grey">(d71341a)</span></li>
<li>server/lib/messengers/partner_publisherRequestReject.js <span style="color: grey">(4284c88)</span></li>
<li>server/lib/payments.js <span style="color: grey">(8e9e533)</span></li>
<li>server/lib/previewstore.js <span style="color: grey">(5776789)</span></li>
<li>server/lib/roles.js <span style="color: grey">(6977dac)</span></li>
<li>server/lib/utils.js <span style="color: grey">(68ee31e)</span></li>
<li>server/main.sh <span style="color: grey">(ed37222)</span></li>
<li>server/package.json <span style="color: grey">(ce291b5)</span></li>
<li>server/public/icons/128/default/application.png <span style="color: grey">(61e8da4)</span></li>
<li>server/public/icons/22/default/application.png <span style="color: grey">(e68dc68)</span></li>
<li>server/public/icons/256/default/application.png <span style="color: grey">(26c352a)</span></li>
<li>server/public/icons/256/default/wallpaper.png <span style="color: grey">(63ea63f)</span></li>
<li>server/public/icons/32/default/application.png <span style="color: grey">(d4afdd4)</span></li>
<li>server/public/icons/512/default/application.png <span style="color: grey">(fb0d8f2)</span></li>
<li>server/public/icons/512/default/wallpaper.png <span style="color: grey">(1c58400)</span></li>
<li>server/public/icons/64/default/application.png <span style="color: grey">(5c36c08)</span></li>
<li>server/routes.js <span style="color: grey">(3b0849f)</span></li>
<li>server/test/accounts.js <span style="color: grey">(128ef39)</span></li>
<li>server/test/api.js <span style="color: grey">(7ee3d53)</span></li>
<li>server/test/assetcreation.js <span style="color: grey">(a57e3e3)</span></li>
<li>server/test/auth.js <span style="color: grey">(ddf1119)</span></li>
<li>server/test/forum.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>server/test/partners.js <span style="color: grey">(880e899)</span></li>
<li>server/test/points.js <span style="color: grey">(b2bf66f)</span></li>
<li>server/test/previewstore.js <span style="color: grey">(0d95713)</span></li>
<li>server/test/purchase.js <span style="color: grey">(991cf65)</span></li>
<li>server/test/ratings.js <span style="color: grey">(15e4e63)</span></li>
<li>server/test/sampleasset/sample-app-info.json <span style="color: grey">(b09e9c1)</span></li>
<li>server/test/support/utils.js <span style="color: grey">(bbe02d3)</span></li>
<li>server/test/tags.js <span style="color: grey">(66c45e6)</span></li>
<li>server/views/passwordreset.jade <span style="color: grey">(aed8095)</span></li>
<li>sql/api.plsql <span style="color: grey">(27816a3)</span></li>
<li>sql/core.plsql <span style="color: grey">(137083d)</span></li>
<li>sql/core.sql <span style="color: grey">(1fa61f2)</span></li>
<li>sql/defaultdata.sql <span style="color: grey">(6d0d0c9)</span></li>
<li>sql/discourse.plsql <span style="color: grey">(02bee9c)</span></li>
<li>sql/discourse.sql <span style="color: grey">(cbd8b87)</span></li>
<li>sql/maintenance.plsql <span style="color: grey">(3d2dac8)</span></li>
<li>sql/purchasing.plsql <span style="color: grey">(eebfa25)</span></li>
<li>sql/ratings.plsql <span style="color: grey">(1f9451d)</span></li>
<li>sql/search_en.plsql <span style="color: grey">(e2456a2)</span></li>
<li>sql/testdata.sql <span style="color: grey">(33fe2b9)</span></li>
<li>sql/vivaldi.sql <span style="color: grey">(c6a0d5c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112965/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>