<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112581/">http://git.reviewboard.kde.org/r/112581/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 12th, 2013, 3:52 p.m. UTC, <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">a button that opens a web browser to the forum page makes the application not self-hosting and very clumsy from a navigational POV (how do you get back to the client? pull down the peek area, close the browser and go back to the add-ons client? ugh)
rather, as discussed, it would be better to be able to show the last N (say, 5) comments in the assets info panel. as with reviews, it might make sense to have a link that says "See what people are saying.." or even just "See feedback..." which would then hide that link and expand to show the last N comments.
this itself could be done in one of two ways: either show the comments in the info pane itself or, and this is my preference atm, open a new column showing the feedback. that panel could then have a "Open the forum..." link that would open a web browser and which would be used to interact with the forum.
additionally, on the "rate and review" popup used to add / edit ratings, there should be a text area in which the user can put some text as a review which then gets added to the forum
really, the web forum part is only for the developer to continue interacting with the feedback and for people who wish to get more involved in the conversation to do so. but the Add Ons app itself should provide a basic display the feedback from the forum without leaving the add-ons app.</pre>
</blockquote>
<p>On September 14th, 2013, 11:48 a.m. UTC, <b>Giorgos Tsiapaliokas</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> and this is my preference atm, open a new column showing the feedback
ok, lets create a new column then.
> to be able to show the last N (say, 5) comments
I don't understand what to add in the column. If we have the asset 'Poker 11' there will be
a category for the asset 'Poker 11' which will have topics which may have >=0 posts.
So, don't we need a column which will show the topics of the asset 'Poker 11' and *another* column
which will show the posts (if any) of the specified topic?
Also we need some Qt code for the discourse API, where should I put it? In libbodega or in another library?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> I don't understand what to add in the column.
it should show the comments from topics under the asset's category from discourse. it is unnecessary to have multiple columns, imho. for instance, just the first comment in each topic/thread in the 'Poker 11' asset could be shown with the ability to expand and show replies if there are any. what is shown in the Add Ons client does not need to be complex.
> Also we need some Qt code for the discourse API
absolutely not. discourse is an implementation in bodega. anything using bodega should not have to rely on the implementation detail of "bodega uses discourse". anything that a client needs to do with the feedback must be available via a bodega API call.
obviously, bodega does not need to wrap the entire discourse API. all it needs is to be able to fetch comments related to an asset and to post a new (top-level) comment as feedback. everything else more than that can be done via the discourse web interface (replying to threads, reading responses to threads, etc.)</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On September 7th, 2013, 5:46 p.m. UTC, Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Bodega.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Sept. 7, 2013, 5:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch
* parses the forum info from asset/:assetId
* adds a button in the ui in order to open the link in the browser</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">attached screenshot
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>activeclient/package/contents/ui/storebrowser/AssetColumn.qml <span style="color: grey">(a678f16)</span></li>
<li>activeclient/src/bodegastore.cpp <span style="color: grey">(ba9dc27)</span></li>
<li>lib/bodega/assetjob.cpp <span style="color: grey">(5f539cb)</span></li>
<li>lib/bodega/globals.h <span style="color: grey">(5ab45da)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112581/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/09/07/forumbutton.png">forumbutton.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>