<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110752/">http://git.reviewboard.kde.org/r/110752/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/110752/diff/2/?file=147668#file147668line25" style="color: black; font-weight: bold; text-decoration: underline;">server/test/support/http.js</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">function getUrl(app, url, fn, cookie) {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">25</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nx">res</span><span class="p">.</span><span class="nx">body</span> <span class="o">=</span> <span class="nx">buf</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No. Please fix this.
It's really irritating to see ten pages of text to show up when running make test.
Either add another argument to getUrl to specify that the output isn't json or use something else than getUrl to test non-json paths.</pre>
</div>
<br />
<p>- Zack</p>
<br />
<p>On June 2nd, 2013, 3:29 p.m. UTC, Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Bodega.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated June 2, 2013, 3:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hello
with that patch i am adding the following support to the bodega-server:
1) server/doc is the place which all of our documentaion lives.
2) The docs are accessible from /api/filename.E.x. for docs/README.markdown => api/README
If you all agree with that patch, i will push it to the branch which i am referring above(kokeroulis/markdown/documentation)
P.S. the two files are from bodega-server and bodega-client</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>server/doc/index.markdown <span style="color: grey">(PRE-CREATION)</span></li>
<li>server/doc/json_api.markdown <span style="color: grey">(PRE-CREATION)</span></li>
<li>server/package.json <span style="color: grey">(09f2527)</span></li>
<li>server/routes.js <span style="color: grey">(95883a9)</span></li>
<li>server/test/api.js <span style="color: grey">(PRE-CREATION)</span></li>
<li>server/test/support/http.js <span style="color: grey">(b9e5cb3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110752/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>